Turn Colors on and off, select wether to use -e #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 29, 2011 18:39
| @@ -0,0 +1,3 @@ | |||
| colors="colors+" | |||
There was a problem hiding this comment.
why a separate file? why not just have an env variable, N_COLORS=0 or N_NO_COLORS=1 etc
There was a problem hiding this comment.
there might even be a generic convention for this, I'm not sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you noted in #12 (comment): "maybe we just need some kind of option or env var to omit colors". Here is the way to do just that. One sets the output mode in the config file (which may be moved away from the bin directory) by changing the
$colorsvariable to either of"colors"(normal color output),"colors+"(color output with -e) or"nocolors"(no colors shown). I hope you don't find to many flaws.Sidenotes:
$BLACK = $RED = $GREEN = $SPECIAL = ""in the nocolors case is not mandatory. But I realized this too late so I left it in.