only extract version numbers from lines which contain <a></a> tags #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt 3.2.0 from
```html
<link href="//dn-staticfile.qbox.me/twitter-bootstrap/3.2.0/css/bootstrap.min.css" rel="stylesheet" media="screen">
```
| MIRROR=(${NODE_MIRROR-https://nodejs.org/dist/} | ||
| ${IO_MIRROR-https://iojs.org/dist/}) | ||
| MIRROR=(${NODE_MIRROR-http://npm.taobao.org/mirrors/node/} | ||
| ${IO_MIRROR-http://npm.taobao.org/mirrors/iojs/}) |
There was a problem hiding this comment.
I think you added this to this PR by accident, you can avoid these situations by always creating a new branch in your fork for each feature you want to create a PR for.
There was a problem hiding this comment.
Thank you very much for pointing this out
|
@tedgaydos What's your thought on this? |
|
I have confirmed that this doesn't affect the output when using the default mirror in any way. Both outputs of |
|
I'll merge this once we decided about how to organise the next versions of n (#276) |
|
👍 Looks good. We can mix it in with 1.4. I was away for a bit. We will get 1.4 out soon. I just noticed that there was a copy error still in 1.3 published to npmjs.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirror website is popular in Asia
I have problems installing nodejs using customized mirror website
because
3.2.0pops up in the list as shown belowI try to find the root cause by myself, it turns out the mirror website source code contains links to bootstrap
so, the problem can be fixed by prepending another
egrep