Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npmjs domain in README #414

Merged
merged 1 commit into from Feb 11, 2017
Merged

Fix npmjs domain in README #414

merged 1 commit into from Feb 11, 2017

Conversation

simeji
Copy link
Contributor

@simeji simeji commented Feb 11, 2017

Changed npm domain to npmjs.com from npmjs.org.

Failure

ubuntu@ubuntu17:~$ curl -0 -L https://npmjs.org/install.sh | sudo sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: npmjs.org

curl npmjs.org

ubuntu@ubuntu17:~$ curl npmjs.org -I
HTTP/1.1 301 Moved Permanently
Server: nginx/1.4.6 (Ubuntu)
Date: Sat, 11 Feb 2017 10:27:36 GMT
Content-Type: text/html
Content-Length: 193
Connection: keep-alive
Location: https://www.npmjs.com/

After npmjs.org => npmjs.com, I get Succeed.

curl -0 -L https://npmjs.com/install.sh | sudo sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   193    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  6263  100  6263    0     0   2932      0  0:00:02  0:00:02 --:--:--  764k
tar=/bin/tar
version:
...
...
...

Change npm domain to npmjs.com from npmjs.org
Copy link

@sam3d sam3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@troy0820
Copy link
Collaborator

LGTM 👍

@troy0820 troy0820 merged commit d6f4400 into tj:master Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants