Hide cursor while selecting version from menu #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged to develop for next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template:
Describe what you did
Hide cursor while selecting node version from menu (i.e.
nvhwith no parameters).How you did it
Added calls to
tputto hide and show cursor inenter_fullscreenandleave_fullscreen. These two routines already usetputto save and restore the screen contents.Added redirection to suppress stderr just in case tput calls not supported by termcap.
Deleted unused code to hide and show cursor using direct escape sequences.
How to verify it doesn't effect the functionality of n
Cosmetic only, not functional.
Tried the termcap calls on Mac High Sierra, Mac Mojave, Ubuntu, Centos, and archlinux.
If this solves an issue, please put issue in PR notes.
On macOS there was a cursor left on screen below version list during version selection from menu, and sometimes a padlock would appear while moving selected version using arrow keys.
If this solves an issue, please include the output of issue that had problems and then the fixed output from the same command.
(graphic difference)
Squash any unnecessary commits to keep history clean as possible
Place description for the changelog in PR so we can tally all changes for any future release
Hide cursor while selecting node version from currently installed versions using menu.