Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add N_PRESERVE_COREPACK #736

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Add N_PRESERVE_COREPACK #736

merged 1 commit into from
Jul 16, 2022

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

The --preserve and N_PRESERVE_NPM features just cover npm (and npx) but not corepack. Users may wish to preserve corepack as well.

See: #735

Solution

It seems reasonable for --preserve to preserve corepack too.

corepack is distributed as an npm package, but it is not part of npm as such. Add a separate environment variable rather than lump it under the existing one.

  • have --preserve cover corepack as well
  • add N_PRESERVE_COREPACK (rather than include corepack in N_PRESERVE_NPM)

ChangeLog

  • also preserve corepack when use --preserve
  • add environment variable for N_PRESERVE_COREPACK

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Jul 16, 2022
@shadowspawn shadowspawn merged commit e20a854 into develop Jul 16, 2022
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Jul 16, 2022
@shadowspawn shadowspawn deleted the feature/preserve-corepack branch August 23, 2022 08:51
polarstoat added a commit to polarstoat/prezto that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant