check only presence but not typeof secret params, fixes #33

tj · Feb 17, 2022 · f1e8911 · f1e8911
1 parent 50db507
commit f1e8911
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -15,7 +15,7 @@ var crypto = require('crypto');
 
 exports.sign = function(val, secret){
   if ('string' != typeof val) throw new TypeError("Cookie value must be provided as a string.");
-  if ('string' != typeof secret) throw new TypeError("Secret string must be provided.");
+  if (null == secret) throw new TypeError("Secret key must be provided.");
   return val + '.' + crypto
     .createHmac('sha256', secret)
     .update(val)
@@ -35,7 +35,7 @@ exports.sign = function(val, secret){
 
 exports.unsign = function(input, secret){
   if ('string' != typeof input) throw new TypeError("Signed cookie string must be provided.");
-  if ('string' != typeof secret) throw new TypeError("Secret string must be provided.");
+  if (null == secret) throw new TypeError("Secret key must be provided.");
   var tentativeValue = input.slice(0, input.lastIndexOf('.')),
       expectedInput = exports.sign(tentativeValue, secret),
       expectedBuffer = Buffer.from(expectedInput),