Avoid infinite loop when a native prototype has an enumerable property #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj
added a commit
that referenced
this pull request
May 7, 2013
Avoid infinite loop when a native prototype has an enumerable property
|
looks like it's broken for 0.11.0 we'll have to check that out, some v8 changes or something. I kinda feel a little meh about all these changes in general, unfortunately it's pretty easy to break just about any node process from the outside in a number of ways but I guess that's not excuse not to try and patch them up haha, node is incredibly brittle though |
|
yeah, this one is silly. people shouldn't be messing with native prototypes, but i guess it's worth preserving compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes expressjs/express#1606