Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making outorg optional #1

Closed
tarsius opened this issue Mar 10, 2014 · 3 comments
Closed

Making outorg optional #1

tarsius opened this issue Mar 10, 2014 · 3 comments

Comments

@tarsius
Copy link

tarsius commented Mar 10, 2014

Would you accept a patch that turns outorg into an optional dependency, e.g. by wrapping the definitions of navi-edit-as-org and navi-mail-subtree with (eval-after-load 'outorg ...)?

@tj64
Copy link
Owner

tj64 commented Mar 10, 2014

Yes, I would - please go ahead.

PS
Would that cause issues for existing user configurations?

@tarsius
Copy link
Author

tarsius commented Mar 11, 2014

I just forked to make then change and only then noticed you have already done it. Thanks.

I think you should still require outorg but make it a soft dependency:

(require 'outorg nil t)

Ps: and not combine whitespace cleanup with other changes.

@tarsius tarsius closed this as completed Mar 11, 2014
@tj64
Copy link
Owner

tj64 commented Mar 11, 2014

Yes, I forgot to close this issue, sorry ... the whitespace cleanup happened by accident.
I will make outorg a soft dependency, thanks for the suggestion.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants