Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tray options #52

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

oleitao
Copy link

@oleitao oleitao commented Jan 3, 2021

Hi,

This is my first contribution to this project. if you allow, I would like to contribute with new improvements and features to this application.

I have added an option to keep the app running as a tray icon, so if the user wants to re-open the application to add new taskbar icons, it can be done more easily.

Let me know if you have any suggestions, you would like me to help with.

Happy new year ;-)!

@PikeNote
Copy link
Contributor

PikeNote commented Jan 3, 2021

I had taken a look at it and I am curious, for frmClient.resx, is there any way to use the resource files already in the project instead of using the base64 encoded version? I thought it most likely would make it a bit cleaner.

@tjackenpacken
Copy link
Owner

Hi!

I'm glad you want to help with the project. The general idea seems great, but that .resx file is really an eyesore. So I'll second Pike's question above!

Happy new year!

@oleitao
Copy link
Author

oleitao commented Jan 3, 2021

Hi!

You are right, I have update my branch, by removing all those changes to the .resx file and maintaining the tray icon.

Glad to contribute :-D!

@PikeNote
Copy link
Contributor

PikeNote commented Jan 4, 2021

Hello! I had recently built and tested it. I think it would be good to not add any more buttons/controls but rather use the native close function and cancel the input from that to close the window. It avoids the need for a button to close the application.

private void frmClient_FormClosing(object sender, FormClosingEventArgs e) {
      e.Cancel = true // Cancels the form closing
      Hide();
      trayIcon.Visible = true;
}

On top of that I think you should add a event to the tray icon so when its clicked, it can bring up the window automatically.

That is about it and this is a great idea! In the future I may look to support settings for the entire client to say turn off this feature but I am not sure currently how to handle such thing yet. Want to get a proper format going before adding any settings.

As a side note, the "When the folder opens" area seems to have its visibility toggled off no matter if there are existing or groups or not.

# Conflicts:
#	main/Forms/frmClient.Designer.cs
#	main/Forms/frmClient.cs
@oleitao
Copy link
Author

oleitao commented Jan 7, 2021

Hi,

I have made a new approach of the "close to tray" feature.

@PikeNote
Copy link
Contributor

PikeNote commented Jan 7, 2021

Looks good but I have a few concerns/suggestions currently that I can think of.

First the tray options seem to appear at the top left of my screen for some reason instead of above the application as the expected behavior is.

Second, I think the application should be launched when first ran instead of only opening in the tray. It takes more steps to open it which may hinder user experience.

Third, I think you should just be able to (if possible) a normal click would just bring up the application automatically without having to click another button and right click be assigned to opening the context menu with the exit. I believe it would make the use a bit more streamlined.

Great work thusfar!

@oleitao
Copy link
Author

oleitao commented Jan 11, 2021

Hi @PikeNote, thanks you,

Well pointed 👍. Fixed the top left screen tray menu.
For some reason in my machine was working fine, but when tested on a clean machine (without any previous installation), the issue was there.

Implemented the launch order you suggested, opening the app on first initialization and then on close put it in tray.

Next commit, I will implement the option to display/expand the window, when tray icon is double clicked.

@oleitao
Copy link
Author

oleitao commented Jan 18, 2021

Hi @PikeNote and @tjackenpacken.

Added some new commits, fixing some previous tray issues and adding the launch on tray click.

@tjackenpacken
Copy link
Owner

Hi @PikeNote and @tjackenpacken.

Added some new commits, fixing some previous tray issues and adding the launch on tray click.

Hi!

I have been busy with some school assignments the past couple of weeks, but will have some more time now. Will try to look into your pull later today. Is your forked repository the latest release + your pull?

@oleitao
Copy link
Author

oleitao commented Jan 22, 2021

Hi @tjackenpacken, no worries.

Yes the fork repo is update with you master branch and synced with my branch add-tray-options

@oleitao oleitao mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants