New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up #24
Clean up #24
Conversation
PS. I've added running node-gyp as build process, now to build up, just
If working just with JS,
|
Alexander, thank you for the submission. It would probably be a while before I got to that level of cleanup and automation. I am not familiar with grunt. What is the advantage of grunt over regular npm scripts declared in package.json? In general I would like to avoid adding dependencies either in runtime or developement environment unless there is a smoking gun reasons to do so. I started doing some automation work by automating the build of edge.js against any version of node.js (dynamically downloaded from http://nodejs.org/dist): check out When I look at what your pull requests brings vs what I am still missing in daily development, there are two things:
Thoughts? |
@tjanczuk regarding
You current You already have jshint check with this pull request, custom builds could be added as well. I can help with that, |
Most native modules in node.js are built with node-gyp. Once edge.js has support for Mono (#3), I expect node-gyp will provide a cross-platform building experience. Given that, what is the value grunt brings to the table beyond what node-gyp and npm offer? Is this an alternative, or does it add value on top of node-gyp+npm? npm already runs mocha when you run I do like the idea of jslint, but that can also be easily done with npm, right? |
Tomasz, to make things a bit easier I would suggest to merge the stuff into local branch and just try
grunt is not alternative to node-gyp or something, it's just convenient way of building JS projects. If you try and don't like it, let me know. |
Let me play with this for a day. I like the value add, but I need to convince myself I am OK with adding the dependency to get it. Does grunt have some first class support for cross-platform (in the sense of "do A in Windows and B on Linux"? |
Yes, it's possible http://jaketrent.com/post/an-environment-specific-grunt-build/ |
Alexander, I thought about this hard and long and I think would like to hold off taking this pull request at this time. Once the mono support is in there may be critical mass to add this. But for the time being I expect only a handful of people to ever need to build edge.js (it comes pre-compiled in Git and npm), and the current set of tools adequate. The one aspect I would love to see is automated run of jshint. If you are so inclined perhaps you could add an |
The issue with throwing out I've added simple linting script as well as new npm script, so now you can run |
Thanks for doing this. A few remaining issues:
|
@tjanczuk I'll find a time to do that and send next pull request soon. jshintrc, could not be moved to Regarding the require statements: my experience in JS shows that multiple Ben Alman's post shows exactly my point. I'm not saying you should use that, but please consider that. I don't remember what exact tweak to disable it, but I can search for it. |
Closing this in lieu of #30 |
In sake of better supportability of project I did few things.
grunt
build system few tasks (jshint, mocha)npm install -g grunt-cli
) you are able to "one command" build app.@tjanczuk, you probably using VS to edit js files, so there are many "tabs on end line", "trainling spaces" errors, I would suggest you turn option to show your tabs/space, since JS does not like it :) (or use some better editors as Sublime + JSLinter).
If you like it, I'll update README and also try to add '
grunt-node-gyp", so build will be as easy as
grunt` command.