Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: openai dive crashes server if there is a network error #66

Closed
densumesh opened this issue May 7, 2024 · 1 comment · Fixed by #69
Closed

bug: openai dive crashes server if there is a network error #66

densumesh opened this issue May 7, 2024 · 1 comment · Fixed by #69
Assignees
@tjardoo

Comments

@densumesh
Copy link
Contributor

densumesh commented May 7, 2024 •
edited
Loading

Whenever OpenAI returns a 502 or doesn't respond over the network, an unwrap within the dive client fails and crashes our entire web server. We are currently on openai-dive 0.4.6

image

The fix is probably changing the unwrap at

openai-client/src/v1/api.rs

Line 123 in 962d0fa

.unwrap();
to be an unwrap_or or adding other error handling and retry logic.

We may get to pring this soon, but wanted to create the issue for visibility.
@tjardoo tjardoo self-assigned this May 8, 2024
@tjardoo
Copy link
Owner

tjardoo commented May 8, 2024

Thanks for reporting! Feel free to create a PR - changing the unwrap() function seems to me indeed the correct approach.

@tjardoo tjardoo linked a pull request May 16, 2024 that will close this issue
Validate status code before unwrap #69
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjardoo tjardoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate status code before unwrap tjardoo/openai-client
2 participants
@densumesh @tjardoo