Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Support for markdown package #8

Open
kieran-mace opened this issue Oct 4, 2017 · 10 comments
Open

Support for markdown package #8

kieran-mace opened this issue Oct 4, 2017 · 10 comments

Comments

@kieran-mace
Copy link

Can you add support for the language-markdown package located here?

@tjkohli
Copy link
Owner

tjkohli commented Oct 6, 2017

Hi @KMace, thanks for the post! I'll consider it. As always, anyone is free to contribute to this as well.

@kieran-mace
Copy link
Author

kieran-mace commented Oct 6, 2017 via email

@sdrakulich
Copy link

I'd like to reboot this. I love this theme, it's my favorite and the one I want to be using.
However, any function in R is blinking and it makes me sad. I'd fix it but I don't know how.

@tjkohli
Copy link
Owner

tjkohli commented May 8, 2018

@sdrakulich can you please send me a sample R file where this happens? I will try to see why it is happening.

@kieran-mace
Copy link
Author

here is an example:

---
title: "R Notebook"
output: html_notebook
---

Simple example to show rmarkdown weirdness.

```{r}
library(dplyr)
library(downloader)
url <- "https://raw.githubusercontent.com/genomicsclass/dagdata/master/inst/extdata/msleep_ggplot2.csv"
filename <- "msleep_ggplot2.csv"
if (!file.exists(filename)) download(url,filename)
msleep <- read.csv("msleep_ggplot2.csv")
head(msleep)
sleepData <- select(msleep, name, sleep_total)
head(sleepData)
```

save that as example.Rmd

@tjkohli
Copy link
Owner

tjkohli commented May 8, 2018

@KMace Unfortunately, this confirms my suspicions. Atom and/or the language-markdown does not seem to support syntax highlighting for R. It doesn't differentiate logic and, therefore, there is no way for my theme to style it. I actually tested this file with both default Atom themes: Atom Dark and One Dark (both UI & Syntax), and neither of them highlight your file any better than Nebula does.

screen shot 2018-05-08 at 7 08 46 pm

@tjkohli
Copy link
Owner

tjkohli commented May 8, 2018

@sdrakulich can you please provide me your sample file that highlights the blinking function? I was not able to reproduce it.

@kieran-mace
Copy link
Author

@tjkohli, you are correct, but if you also install the language-markdown here: https://github.com/burodepeper/language-markdown

you get the following:

screen shot 2018-05-08 at 4 23 26 pm

@kieran-mace
Copy link
Author

kieran-mace commented May 8, 2018

language-markdown has support for different themes, with instructions listed here:
https://github.com/burodepeper/language-markdown/blob/master/CONTRIBUTING.md#syntax-theme-support

@tjkohli
Copy link
Owner

tjkohli commented May 9, 2018

@KMace I have had the language-markdown installed. Just installed minimal-syntax theme, and doesn't seem like it's highlighting your logic either. Perhaps there is something wrong with my Atom install.

screen shot 2018-05-08 at 8 44 26 pm

Just to be clear, you have an issue with the error underlining in .Rmd, am I correct?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants