Improved isVisible logic & readability. #230 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2017
tjoskar
approved these changes
Dec 31, 2017
|
|
||
| it('Should be vissible when only left side with no corners is in the viewport', () => { | ||
| const element = generateElement(-100, 500, 1200, 1200); | ||
| debugger; |
There was a problem hiding this comment.
All these debug statement should be removed. I know, it was me how added them and I'm ashamed.
(You do not have to do anything, I will clean up my mess)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I have corrected the issue that was described in #230.
I also introduced a very simple Rect class, which in my opinion greatly improves the readability and simplicity of the
isVisiblefunction.After some performance tests, the Rect implementation turned out to be slightly faster than the current one. ~1.54% faster on Chrome and ~20.75% faster on Firefox, tested with 10,000,000 iterations averaged over 3 runs.
The only "problem" with this implementation is that the
onLoad eventexample page is not functioning anymore.This happens because the example is flawed. It's because
getBoundingClientRectreturns 0 sized rectangle, if the element is hidden. So I don't think it's a problem with my implementation at all.I will open a separate issue regarding the flawed implementation.
EDIT: The example is not a problem anymore with #240.