Use unmodifiable collection in UnitSeperator in Swing Event Thread Ta… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk (#7070) Fixes #7066 UnitSeparator#categorize:103 - ConcurrentModificationException This fix avoids concurrent modification to a list by creating a copy of the list before we operate on the list in the swing even thread. We go on to fix any other data issues that could change between when we issue the task to the swing event queue by computing all data the task needs before creating the task.
tjrbrom
pushed a commit
that referenced
this pull request
Jul 28, 2022
* docuStartContribute #1 contribute.md - Initial page "Contribute to TripleA" README.md - Link to new page "Contribute to TripleA" * docuStartContribute #1 contribute.md - Initial page "Contribute to TripleA" README.md - Link to new page "Contribute to TripleA" * docuStartContribute #2 contribute.md - icons try 1 * docuStartContribute #3 contribute.md - icons try2 * docuStartContribute #4 contribute.md - cleanup * docuStartContribute #5 contribute.md - New role: Donor . Map Maker: Skillset * Update contribute.md The Rules Guru profile. I changed "Guru" to "Expert" however 😃 . * Rule Expert link + Capitalization of Roles * Update Forum Moderator See if i did this correctly lol * Update contribute.md Added to Map Maker Skillset * docuStartContribute #6 contribute.md - New roles: Map Admin, Release Tester * Contribute page: TBD for Release Tester + Developer with Merge Rights 🔍 Release Tester - How to become one 🔨 Developer with Merge Rights - How to become one * Update contribute.md See the differences. * Forum Moderator -> Lobby Moderator #2 renaming/linking * ContributePage: Remove *Work in Progress* Co-authored-by: Panther P2 <panther2@users.noreply.github.com> Co-authored-by: beelee1 <timbucktoomany@gmail.com> Co-authored-by: TheDog-GH <71022517+TheDog-GH@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sk (triplea-game#7070)
Fixes triplea-game#7066 UnitSeparator#categorize:103 - ConcurrentModificationException
This fix avoids concurrent modification to a list by creating a copy
of the list before we operate on the list in the swing even thread.
We go on to fix any other data issues that could change between when
we issue the task to the swing event queue by computing all data
the task needs before creating the task.
Functional Changes
[] New map or map update
[] New Feature
[] Feature update or enhancement
[] Feature Removal
[] Code Cleanup or refactor
[] Configuration Change
[] Problem fix
[] Other:
Testing
Screens Shots
Additional Notes to Reviewer
Release Note