Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version strings are combined using a culture dependent NumberDecimalSeparator #92

Closed
glienard opened this issue Nov 28, 2020 · 3 comments
Closed

Version strings are combined using a culture dependent NumberDecimalSeparator #92

glienard opened this issue Nov 28, 2020 · 3 comments

Comments

@glienard
Copy link
Contributor

Ran into this problem on one of our European servers.

System.FormatException: Input string was not in a correct format.
  at System.Number.ParseDouble(String value, NumberStyles options, NumberFormatInfo numfmt)
  at System.Convert.ToDouble(String value)
  at RoboSharp.VersionManager.get_Version() in C:\GitHub\RoboSharp\RoboSharp\VersionManager.cs:line 41
  at RoboSharp.CopyOptions..ctor() in C:\GitHub\RoboSharp\RoboSharp\CopyOptions.cs:line 52
  at RoboSharp.RoboCommand..ctor() in C:\GitHub\RoboSharp\RoboSharp\RoboCommand.cs:line 24
glienard added a commit to glienard/RoboSharp that referenced this issue Nov 28, 2020
@glienard
tjscience#92 Use dot as NumberDecimalSeperator independent of current…
f350895 
… culture
@Jascha-W3DG
Copy link

Any chance the fix will make it into the stable release? This issue also happens on French systems.

tjscience added a commit that referenced this issue Jul 30, 2021
@glienard @tjscience
#92 Use dot as NumberDecimalSeperator independent of current culture (#…
17a4cb7 
…93)

Co-authored-by: Terry Phillips <terry.w.phillips@gmail.com>
@Jascha-W3DG
Copy link

Hey,

sadly this was not the best fix, since its now broken on German systems too

@tjscience tjscience reopened this Aug 4, 2021
@tjscience
Copy link
Owner

@Jascha-W3DG, this has been fixed and 1.2.4 has been pushed to nuget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tjscience @Jascha-W3DG @glienard