Skip to content

Commit

Permalink
Merge b1a4393 into c9f5c8c
Browse files Browse the repository at this point in the history
  • Loading branch information
TheJaredWilcurt committed Sep 19, 2020
2 parents c9f5c8c + b1a4393 commit d714751
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 20 deletions.
21 changes: 18 additions & 3 deletions .github/workflows/node.js.yml
Expand Up @@ -3,13 +3,17 @@

name: Node.js CI

env:
COVERALLS_REPO_TOKEN: "${{ secrets.COVERALLS_REPO_TOKEN }}"
COVERALLS_GIT_BRANCH: "${{ github.head_ref }}"

on:
push:
branches: [ master ]
pull_request:
branches: [ master ]

jobs:
jobs:
build:

runs-on: ubuntu-latest
Expand All @@ -33,5 +37,16 @@ jobs:

- run: npm ci
- run: npm run lint
- run: npm run coverage
- run: jest --runInBand

- if: ${{ startsWith(matrix.node-version, '10.') || startsWith(matrix.node-version, '12.') }}
run: npm t

- if: ${{ startsWith(matrix.node-version, '14.') }}
run: npm run coverage

# - if: ${{ startsWith(matrix.node-version, '14.') }}
# name: Coveralls GitHub Action
# uses: coverallsapp/github-action@v1.1.2
# with:
# github-token: ${{ secrets.github_token }}
# path-to-lcov: ./coverage/lcov.info
14 changes: 0 additions & 14 deletions .travis.yml

This file was deleted.

3 changes: 1 addition & 2 deletions package.json
Expand Up @@ -10,8 +10,7 @@
"test-debug": "node --inspect-brk ./node_modules/jest/bin/jest.js --no-cache --runInBand -t \"ObjectAttribute\"",
"coverage": "jest --coverage --runInBand --coverageReporters=text-lcov | coveralls",
"validate": "npm run lint && npm test",
"remote": "git remote rm eddyerburgh && git remote",
"travis": "npm run lint && npm run coverage && jest --runInBand"
"remote": "git remote rm eddyerburgh && git remote"
},
"ManifestComments": [
"Pinned jest to 24.9.0. 25.1.0 is broken on Windows. Waiting for issue #9459 to be resolved."
Expand Down
2 changes: 1 addition & 1 deletion tests/src/helpers.test.js
Expand Up @@ -51,7 +51,7 @@ describe('Helpers', () => {
describe('cloneVnode', () => {
test('No vnode', () => {
expect(helpers.cloneVnode({}, {}, jest.fn()))
.toEqual(undefined);
.toEqual('THIS WAS INTENTIONALLY BROKEN TO SEE IF COVERALLS LOWERS TEST COVERAGE ON THE BRANCH PROPERLY');
});
});
});

0 comments on commit d714751

Please sign in to comment.