Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csZbar plugin improvement #11

Merged
merged 15 commits into from
Feb 27, 2015
Merged

csZbar plugin improvement #11

merged 15 commits into from
Feb 27, 2015

Conversation

PaoloMessina
Copy link
Contributor

With this pull request i would like to include in your project:

iOs BugFixing
Android BugFixing
iOS x64 static file for zBar lib.a
Adding a sight to the overlay view of the camera ( parameter to not use it )

PaoloMessina and others added 15 commits December 22, 2014 14:59
iOS:
- x86_64 header fixing
- sight adding

Android:
- Bug fix no params NullPointerException
- sight adding
iOS sight missing
Cynogen camera auto focus bug
Continuos auto focus fix for sony device
Commit Android Label and rect sight removing
Fix android release
Adding camera.cancelAutoFocus(); some devices crashes
Adding a line sight landscape
Adding landscape sight for iOS terminal, bug fix on iPad
Commit relative layout
android bugfix
Android default drawSight = true
iOS default drawSight = true
Commi plugin.xml
Manage onAutoFocus Android
@Felix-Weber
Copy link

Looks like this is a great pull request! Especially "iOS x64" support works fine for me! Thanks a lot!

@lmk123
Copy link

lmk123 commented Feb 16, 2015

It's really a great pull request !

@tjwoon
Copy link
Owner

tjwoon commented Feb 16, 2015

Hi @PaoloMessina. First of all thank you very much for enhancing this plugin and sending this pull request!

I'd just like to update everyone here that I have looked at the pull request briefly, and cannot merge it into this plugin directly, as some code is removed and changed, instead of just adding new functionality/etc.

Also, I'd really like to check and verify the source of the new iOS .a binary.

I will be working on this soon. Sorry for the slow pace of things - work has been heavy recently. Good news is that I will be needing this plugin for work quite soon, so I will be forced to work on this plugin :D

@tjwoon tjwoon mentioned this pull request Feb 16, 2015
@tjwoon tjwoon merged commit 633b5f7 into tjwoon:master Feb 27, 2015
@tjwoon
Copy link
Owner

tjwoon commented Feb 27, 2015

Hi @PaoloMessina

I have merged your pull request with some changes:

  • Unnecessary Android removals/changes removed.
  • Reapplied hack to hide the iOS scanning view's Info button.
  • Changed the drawSight option to a boolean instead of string (JavaScript side).
  • Minor code style changes.

Once again, thank you very much for your very valuable contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants