Bug fixes and optimizations #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding button to activate/deactivate flash during the capturing the phase.
Added a method to turn on the camera's flash during the scanning process. Added some block in to handle the device orientation
Added a method to turn on the flash button
Fix the sigh light size on device orientation change
A change to activity configuration has been made to allow the orientation change.
update so files to be compatible with android M (23)
Orientation change and flash button added
…es, such as the Nexus 5x. Fixes issue # 50 tjwoon#50
wait until viewController is dismissed before callback, fixes tjwoon#47
…ch as the Galaxy S3, to finish focusing before it tries to refocus. Before this change it was appearing as if the autofocus wasn't working at all, because it kept resetting the focus before it got a chance to focus.
…s. Samsung Tab 4 was crashing because it didn't have a flash or autofocus.
adding support lib to plugin.xml
|
I'll be on this this week. ACK 39af9e1 |
Pulling in latest changes from tjwoon master.
| @@ -194,7 +196,7 @@ public void onResume () | |||
| Log.d("csZBar", "Unsupported camera parameter reported for flash mode: "+flashMode); | |||
| } | |||
|
|
|||
| tryStartPreview(); | |||
| tryStartPreview();*/ | |||
There was a problem hiding this comment.
Can you just remove the unused code, not comment it out?
Merged
|
Closed in favour of #66 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request from my own fork where I pulled in other pull requests from #36 and #39 and also added in some bug fixes including:
This has been tested on Samsung Tab 4, Samsung Galaxy S3, Samsung Galaxy S4, Samsung Galaxy S5, Nexus 5x, iPhone 4, iPhone 5, and iPhone 6.