New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseString split can cost performance hit? #29

Closed

prasad83 opened this issue Dec 5, 2014 · 1 comment

prasad83 commented Dec 5, 2014

parseString function splits the xmlString on < to determine open-nodes.
Doesn't it lead to performance issue.

function parseString(xml, options, callback) {
    //...
    if (xml.split('<').length >= 3) {

How about taking xml.substring(0, 255) and expecting 3 open nodes to possibly fall into it?

Owner

tk120404 commented Jan 21, 2018

no activity. closing the issue

tk120404 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment