Use native #[proc_macro] support if rustc is new enough #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to its own readme, the proc-macro-hack crate was superseded by native support for #[proc_macro] in expression position in Rust 1.45. Besides that, proc-macro-hack is known to cause issues with rust-analyzer, a popular language server for Rust. A somewhat important consequence of these issues is that using the const_random macro makes Rust Analyzer yield an spurious "unresolved macro" error, which is annoying. To improve on this situation without bumping MSRV, let's use native rustc support when available. This can slightly modify the macro hygiene, although I didn't notice any glaring difference. Related Rust Analyzer project issues and PRs: rust-lang/rust-analyzer#7221 rust-lang/rust-analyzer#9128
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to its own readme, the proc-macro-hack crate was superseded by native support for
#[proc_macro]in expression position in Rust 1.45. Besides that, proc-macro-hack is known to cause issues with rust-analyzer, a popular language server for Rust. A somewhat important consequence of these issues is that using theconst_randommacro makes Rust Analyzer yield an spurious "unresolved macro" error, which is annoying.To improve on this situation without explicitly bumping MSRV, let's use native rustc support when available. This can slightly modify the macro hygiene, although I didn't notice any glaring difference.
Related Rust Analyzer project issues and PRs:
rust-lang/rust-analyzer#7221
rust-lang/rust-analyzer#9128