feat: Generate constant random byte arrays #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `const_random` macro will now accept and generate fixed sized `u8` arrays of any size. Implementation detail: This patch replaces the 256 bit fixed sized sha3 hash (sha3-256) with the sha3 eXtendable-Output Function (SHAKE256). This is to allow arbitrarily long byte arrays to be generated. This is not strictly necessary because `tiny-keccak` does not limit the output size of sha3 functions but I feel that misusing crypto primitive is a code smell.
tkaitchuck
approved these changes
Oct 25, 2022
tkaitchuck
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
const_randommacro will now accept and generate fixed sizedu8arrays of any size. #22
Implementation detail: This patch replaces the 256 bit fixed sized sha3
hash (SHA3-256) with the sha3 eXtendable-Output Function (SHAKE256).
This is to allow
arbitrarily long byte arrays to be generated. Replacing SHA3-245 is not strictly
necessary because the
tiny-keccakcrate does not limit the output size of sha3functions, but I feel that misusing crypto primitives is a code smell.