-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer: Refactor to use @import rather than concatting files #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged to latest master.
|
tkashkin
reviewed
Jul 28, 2023
tkashkin
reviewed
Jul 28, 2023
Updated to address those issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180
Partially Fixes #178
Partially Fixes #177
General
web
has been renamed toadwaita
Installer
The
adwaita
folder is now copied tosteamui/adwaita
during installRather than concatting together a single file, the generated
steamui/libraryroot.custom.css
now contains multiple import statements pointing toadwaita
throughsteamloopback.host
ala:Colorthemes
Colorthemes are now plain css and imported in
libraryroot.custom.css
The old colortheme directory remains for compatability sake until I fix AdwSteamGtk to compensate.
Custom CSS
While we technically supported custom CSS before, it wasn't as discoverable. It is now an option in the installer.
Users can edit
adwaita/custom/custom.css
and provide the-cu
flag to enable it.Not the happiest with the placement of it residing inside the theme dir, any ideas?
Variants
There's really no need for
base
anymore.While the underlying files will need a merge down the line, the
-w
flag is deprecated and now does nothing.Remains for the sake of AdwSteamGtk compatability.