Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Proton versions detection #101

Closed
neuromancer opened this issue Oct 12, 2018 · 17 comments
Closed

New Proton versions detection #101

neuromancer opened this issue Oct 12, 2018 · 17 comments

Comments

@neuromancer
Copy link
Contributor

The versions of Proton used by GameHub are hardcoded:

https://github.com/tkashkin/GameHub/blob/dev/src/data/compat/Proton.vala#L27

It's using 3.7-2 despite the last release is 3.7-8. Can we have the latest available release or at least let the user to change the appid if necessary?

@tkashkin
Copy link
Owner

Did they actually changed appid? It will work if not.

Also there probably should be some file in Steam client with available versions list.

@neuromancer
Copy link
Contributor Author

Uhm. I think we are using the latest version, but for some reason, Proton always reports 2.7-2 in the logs:

https://github.com/ValveSoftware/Proton/blob/8c137019333c3d658e6423028ea27619ba7b9226/proton.in#L21

@tkashkin
Copy link
Owner

There's now Proton 3.16 with appid 961940:

"appid"      "961940"
"name"       "Proton 3.16"
"installdir" "Proton 3.16"

Do you have any better ideas than iterating steamapps/appmanifest_*.acf and trying to use anything with "Proton" in name?

I've looked in Steam configs and haven't found anything useful.

It's possible to add an entry in settings, but that does not seem to be very user-friendly.

@tkashkin tkashkin reopened this Oct 13, 2018
@tkashkin tkashkin changed the title GameHub uses an old version of Proton (3.7-2) New Proton versions detection Oct 13, 2018
@neuromancer
Copy link
Contributor Author

If we are monitoring the Proton progress, I think it is reasonable to hard-code the appids and ask the users to upgrade GameHub when there is a new version of Proton.

@tkashkin tkashkin added this to the Non-native milestone Oct 31, 2018
tkashkin added a commit that referenced this issue Dec 28, 2018
Fix Proton prefix init
Add simple download speed counter
@Hedronmx
Copy link

Anyway I can update the proton version used in GameHub? Right now im at 3.16, and on my steam client it says 3.16-8 beta

@neuromancer
Copy link
Contributor Author

Isn't Proton 3.16 beta the last one?

@tkashkin
Copy link
Owner

@Hedronmx minor Proton updates are not separate Steam apps. GameHub will use latest Proton version as long as app ids are same.

When new major Proton version releases in a new Steam app it needs to be added to the list: https://github.com/tkashkin/GameHub/blob/dev/src/data/compat/Proton.vala#L27

@Hedronmx
Copy link

I see, Thanks!

@gwemmie
Copy link

gwemmie commented Mar 28, 2019

Wait, I'm confused about something. Doesn't GameHub just launch a Steam game by telling Steam to launch it via the command line? And if so, shouldn't Steam then know exactly how Proton is configured for that game, if it's being used at all, and use the correct version as if you had pressed the Play button right in Steam? Is this issue only referring to what GameHub says about Proton versions, regardless of what actually happens when it tells Steam to launch a Proton game?

If yes to all of that, then I'm good.

If no to all of that, then hoo boy, I don't understand how launching Proton games through GameHub is reasonable at all until this becomes a whole lot more automatic. Proton versions and also Steam's launch settings--stuff like parameters and environment variables--are extremely vital parts of getting many Proton games running in my experience. I'd like to be able to just have those set in Steam and then have GameHub blindly tell Steam to launch that game the way it knows how.

@tkashkin
Copy link
Owner

tkashkin commented Mar 28, 2019

@Jimi-James

Doesn't GameHub just launch a Steam game by telling Steam to launch it via the command line?

Yes, exactly, GameHub launches Steam games via steam://rungameid/<appid> URL protocol.

However Gamehub also supports launching non-Steam games with Proton, and in this case Steam client itself is not used at all. GameHub uses Proton builds provided by Steam (user needs to install them manually using Steam client).

@jarrard
Copy link

jarrard commented Apr 2, 2019

proton 4.2 is not detected for me.

Its appid is 1054830

@tkashkin
Copy link
Owner

tkashkin commented Apr 2, 2019

@jarrard it should be detected in latest GameHub version. Check:

  • GameHub version
  • Do you have Proton 4.2 fully installed and unpacked? It should have dist directory when it's unpacked. If it's not, you should run any game with this Proton version via Steam client to complete installation

@jarrard
Copy link

jarrard commented Apr 3, 2019

The gamehub version is not specified anywhere obvious. Anyway I'm using 0.13.1.1.master-1 from the AUR and it does not detect proton 4.2 which I have been using with steam so it is 100% unpacked.

$HOME/.steam/steam/steamapps/common/Proton 4.2/ : this is the location of my proton 4.2

It does detect wine32 and wine64, custom script does nothing. When I had proton 3.16 installed it showed up in the list but not proton 4.2

@tkashkin
Copy link
Owner

tkashkin commented Apr 3, 2019

@jarrard

The gamehub version is not specified anywhere obvious

It's shown:

  • In terminal output
  • With com.github.tkashkin.gamehub -v or --version CLI argument
  • In About dialog (that's recent and not available in master branch yet).

Anyway I'm using 0.13.1.1.master-1 from the AUR

Proton appids are currently hardcoded and GameHub needs to be updated to use newer Proton versions. Proton 4.2 appid and many other improvements are not in master branch yet.
You need to update to dev branch. There's gamehub-git package in AUR.

@jarrard
Copy link

jarrard commented Apr 3, 2019

Ahh, well that explains it, I wasn't sure if the git version was newer or not.

@tkashkin
Copy link
Owner

f88b0a4 improves binary vdf parser so it can now read appinfo.vdf and packageinfo.vdf.

It will allow to implement automatic Proton versions detection.
It seems that Proton is contained in Steam sub package 0 so it should be easy enough.

@tkashkin
Copy link
Owner

Now GameHub will parse appinfo.vdf and find all available Proton versions.

Detected Proton versions are shown in settings:
image

hagabaka pushed a commit to hagabaka/GameHub that referenced this issue Aug 23, 2019
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Fix Proton prefix init
Add simple download speed counter


Former-commit-id: 1825920
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants