Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by source shows games from different sources when merge games is disabled #259

Closed
hlechner opened this issue Jun 21, 2019 · 2 comments

Comments

@hlechner
Copy link

hlechner commented Jun 21, 2019

Expected behavior

Filter by source (steam, gog, humble, local) should only display the games from that source selected.

Actual behavior

By disabling the Merge games from different sources option, seems that it still shows same games as merged, so, it shows as duplicated:
image
image

The reason for that, seems to be related to the fact that the steam games do not lose the merged icons:
image
image

Steps to reproduce

With the GameHub with merged games on it, go to: Settings > Behavior

  • Disable the Merge games from different sources
  • Restart the GameHub to the changes take effect
  • Filter the source (GOG or Humble)

And will see that the previously merged game from steam is there too

Version and environment
Version: 0.14.0-4f32825-makepkg
Branch:  makepkg
Commit:  4f32825 (4f3282591552a3930c8c696b5c4f46b3135e771e)
Distro:  NAME=Arch Linux
DE:      Yaru:ubuntu:GNOME
tkashkin added a commit that referenced this issue Jun 21, 2019
Do not try to show merged games when merging is disabled (#259)
@tkashkin
Copy link
Owner

It should be fixed.

@hlechner
Copy link
Author

Also fixed.

Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Do not try to show merged games when merging is disabled (tkashkin#259)


Former-commit-id: b126539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants