Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clap #55

Merged
merged 9 commits into from
Jan 8, 2022
Merged

Use clap #55

merged 9 commits into from
Jan 8, 2022

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jan 8, 2022 •
edited
Loading

This PR:

  • Relates to Better CLI implementation #51
  • Use clap for handling command line
  • Replace the build system based on Nix with Github actions
  • Add .editorconfig file for auto configuration of the IDE

@drupol
Copy link
Collaborator Author

drupol commented Jan 8, 2022

@tkellogg Could you please enable the CI on this PR please? I think it's just a button to click in this PR.

@tkellogg
Copy link
Owner

tkellogg commented Jan 8, 2022

I'm not seeing an option
image

@drupol drupol marked this pull request as ready for review January 8, 2022 23:05
@drupol drupol requested a review from tkellogg as a code owner January 8, 2022 23:05
@drupol
Copy link
Collaborator Author

drupol commented Jan 8, 2022 •
edited
Loading

Normally there is an option to enable the CI to run, check this maybe?

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#configuring-required-approval-for-workflows-from-public-forks

@drupol drupol mentioned this pull request Jan 8, 2022
Closed
drupol
drupol commented Jan 8, 2022
View reviewed changes
.github/workflows/build.yaml
@@ -1,6 +1,6 @@
name: Build and test

on: [push]
on: [push, pull_request]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#facepalm ... sorry my bad !

@tkellogg tkellogg merged commit adaf6ec into tkellogg:master Jan 8, 2022
@drupol drupol deleted the feat/use-clap branch January 8, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkellogg tkellogg tkellogg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drupol @tkellogg