Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client.py #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update client.py #69

wants to merge 1 commit into from

Conversation

gitrope
Copy link

@gitrope gitrope commented Oct 24, 2021

update of the archive website link

update of the archive website link
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #69 (a503b8c) into master (7ecf732) will increase coverage by 1.94%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   80.55%   82.50%   +1.94%     
==========================================
  Files           5        6       +1     
  Lines         360      400      +40     
==========================================
+ Hits          290      330      +40     
  Misses         70       70              
Impacted Files Coverage Δ
mopidy_internetarchive/client.py 42.22% <50.00%> (ø)
mopidy_internetarchive/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ecf732...a503b8c. Read the comment docs.

@tkem
Copy link
Owner

tkem commented Oct 27, 2021

@gitrope: Did I miss something?

I mean, changing the default BASE_URL to https makes sense, but is there anything preventing you from using plain http?

A rationale for your PR would be helpful...

@gitrope
Copy link
Author

gitrope commented Nov 22, 2021

I apologize for the delay in my reply. I tried on several machines running debians 10 and the link to http didn't work. I can't seem to find the cause other than the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants