Resync ip if pod uid changed #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenchun
force-pushed
the
reserve
branch
8 times, most recently
from
35dc0ab
to
f7e8e4b
Compare
- Previously, resync does nothing if pod name unchanged because it checked pod running only by name - Delete resyncNoneDpPod which is a duplicate func of unbindNoneDpPod - Ipam instead of floatingip plugin desides how to store attributes. So later we can update nodeName and podUid to be specific fields of fip crd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checked pod running only by name
So later we can update nodeName and podUid to be specific fields of fip crd