Skip to content

Commit

Permalink
fix(application): rm app phase chart fetched
Browse files Browse the repository at this point in the history
  • Loading branch information
xdonggao committed Feb 9, 2022
1 parent be8d413 commit 7e8a866
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
3 changes: 0 additions & 3 deletions api/application/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,6 @@ const (
type AppPhase string

const (
// ChartFetched means the chart to which the App refers
// has been fetched successfully
AppPhaseChartFetched AppPhase = "ChartFetched"
// ChartFetchedFailed means the chart to which the App
// refers could not be fetched.
AppPhaseChartFetchFailed AppPhase = "ChartFetchFailed"
Expand Down
8 changes: 0 additions & 8 deletions pkg/application/controller/app/action/pull.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,6 @@ func Pull(ctx context.Context,
updateStatusFunc(ctx, app, &app.Status, newStatus)
return destfile, err
}
newStatus.Phase = applicationv1.AppPhaseChartFetched
newStatus.Message = ""
newStatus.Reason = ""
newStatus.LastTransitionTime = metav1.Now()
_, err := updateStatusFunc(ctx, app, &app.Status, newStatus)
if err != nil {
return destfile, err
}
}
return destfile, err
}
2 changes: 0 additions & 2 deletions pkg/application/controller/app/app_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,6 @@ func (c *Controller) handlePhase(ctx context.Context, key string, cachedApp *cac
return c.syncAppFromRelease(ctx, cachedApp, app)
case applicationv1.AppPhaseRollbackFailed:
break
case applicationv1.AppPhaseChartFetched:
break
case applicationv1.AppPhaseChartFetchFailed:
break
case applicationv1.AppPhaseSyncFailed:
Expand Down

0 comments on commit 7e8a866

Please sign in to comment.