fix(monitor): fix bug in prometheusrule #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. idelta interval(2m) is not matched with prometheus scrape_interval(default is 1m), this will make the related series have break point frequently 2. (container_memory_usage_bytes - container_memory_cache) is not container's real memory use container_memory_working_set_bytes to replace it
huxiaoliang
approved these changes
May 9, 2023
leoryu
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idelta interval(2m) is not matched with prometheus scrape_interval(default is 1m), this will make the related series have break point frequently
(container_memory_usage_bytes - container_memory_cache) is not container's real memory use container_memory_working_set_bytes to replace it
What type of PR is this?
What this PR does / why we need it:
this pr fix bugs in prometheus record rules