Skip to content

Commit

Permalink
Make _lq! definition more permissive
Browse files Browse the repository at this point in the history
  • Loading branch information
tkf committed Aug 19, 2019
1 parent e7c4f94 commit adc4a84
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/utils/array_utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module ArrayUtils
using Base: typename

using LinearAlgebra
using LinearAlgebra: QRPackedQ, LQPackedQ
using LinearAlgebra: QRPackedQ, LQPackedQ, BlasFloat

using ForwardDiff: Dual
using StaticArrays: SVector, SMatrix, StaticArray, Size, similar_type
Expand Down Expand Up @@ -85,12 +85,14 @@ zero_if_nan(x) = isnan(x) ? zero(x) : x
A
end

function _lq!(A)
const MatrixWithLQ = StridedMatrix{<:BlasFloat}

function _lq!(A::MatrixWithLQ)
L, Q = lq!(A)
return (LowerTriangular(L), Q)
end

function _lq!(A::SMatrix)
function _lq!(A)
Q, R = qr(A')
return (LowerTriangular(R'), Q')
end
Expand Down

0 comments on commit adc4a84

Please sign in to comment.