Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a friendly instruction upon ImportError #5

Merged
merged 16 commits into from
May 12, 2018
Merged

Print a friendly instruction upon ImportError #5

merged 16 commits into from
May 12, 2018

Conversation

tkf
Copy link
Owner

@tkf tkf commented May 11, 2018

fixes #4

@tkf tkf force-pushed the importerror branch 2 times, most recently from f00bf42 to 3f05882 Compare May 11, 2018 07:17
@codecov-io
Copy link

codecov-io commented May 11, 2018

Codecov Report

Merging #5 into master will increase coverage by 15.04%.
The diff coverage is 72.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #5       +/-   ##
===========================================
+ Coverage   57.89%   72.94%   +15.04%     
===========================================
  Files           1        4        +3     
  Lines          19       85       +66     
===========================================
+ Hits           11       62       +51     
- Misses          8       23       +15
Impacted Files Coverage Δ
src/IPython.jl 100% <ø> (+42.1%) ⬆️
src/julia_repl.jl 53.33% <53.33%> (ø)
src/core.jl 75% <75%> (ø)
src/convenience.jl 76.92% <76.92%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c377d4...fe49ab2. Read the comment docs.

@coveralls
Copy link

coveralls commented May 11, 2018

Pull Request Test Coverage Report for Build 40

  • 61 of 84 (72.62%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+15.05%) to 72.941%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core.jl 3 4 75.0%
src/julia_repl.jl 8 15 53.33%
src/convenience.jl 50 65 76.92%
Totals Coverage Status
Change from base Build 14: 15.05%
Covered Lines: 62
Relevant Lines: 85

💛 - Coveralls

@tkf tkf merged commit fe49ab2 into master May 12, 2018
@tkf tkf deleted the importerror branch May 12, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cryptic error when the package is loaded, but julia isn't installed in Python
3 participants