Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use request.el #95

Merged
merged 8 commits into from
Jan 17, 2013
Merged

Use request.el #95

merged 8 commits into from
Jan 17, 2013

Conversation

tkf
Copy link
Owner

@tkf tkf commented Dec 29, 2012

Use request.el (https://github.com/tkf/emacs-request) to avoid bugs in url.el.

This branch passes the test:
https://travis-ci.org/tkf/emacs-ipython-notebook/builds/3872279
But I need to test it in real use more before merge. Probably I should add more unit/functional tests.

I think it is usable. If you are courageous please use it and report bug if you find it.


Check list before merge:

  • Make sure that request.el is installable from MELPA
  • Add request.el as a dependency in el-get recipe

@tkf
Copy link
Owner Author

tkf commented Dec 29, 2012

Hmm... it looks like ein:testing-delete-untitled0 fails randomly
https://travis-ci.org/tkf/emacs-ipython-notebook/jobs/3872563

@tkf
Copy link
Owner Author

tkf commented Jan 9, 2013

To support log-in, I need to finish tkf/emacs-request#1 first, so that I can re-implement the workaround for url-retrieve.

* The url.el bug 12374 is fixed and request.el provides
  monkey patch.   There is no need for the workaround now.
* request-response-redirects does not exist anymore.
@tkf tkf merged commit 10db056 into master Jan 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant