Add support for Python3 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,12 +117,12 @@ def run_dot(code, options=[], format='png'): | |||
| try: | |||
| # Graphviz may close standard input when an error occurs, | |||
| # resulting in a broken pipe on communicate() | |||
| stdout, stderr = p.communicate(code) | |||
| except (OSError, IOError), err: | |||
| stdout, stderr = p.communicate(code.encode("utf-8")) | |||
There was a problem hiding this comment.
Don't you need to decode stderr? Probably when raising RuntimeError?
There was a problem hiding this comment.
It works without but the error message gets surrounded by a b'...' which I didn't notice before. So I added it now.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually this also needs to update Sphinx to the current stable branch (support of Python3 for InheritanceGraph was added just after 1.1.3 was released) but assuming you have that installed then this works (and is still compatible with 2.6+).