-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto package for rn encoding/decoding/decryption #278
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
a0979f2
to
8d3b31d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG it's happening!! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good for the most part. Shaping up to have 3 separate concerns: encoding-related, crypto(graphy), and math. Ultimately trust your judgment on how to divvy it all up
6bdc724
to
cd6088a
Compare
1d8b8fe
to
fec03c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 just some minor comments. looking ready to ship soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀🚀🚀
Summary & Motivation
This package will serve as the primitives associated with decryption, encryption and keygen. The goal here was originally to make email auth available in a much simpler way for rn clients, but this actually is just a purjs implementation for any runtime for (primarily) hpke decryption. Currently there are some hardcoded values that are tk specific but a fast-follow is generalizing this for anyone to use.
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset
.pnpm changeset
will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.