Moe/add hpke encryption #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
moe-dev
force-pushed
the
moe/add-hpke-encryption
branch
from
80fda6b
to
2eeb3f0
Compare
andrewkmin
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Looks great overall. Just some minor changes requested but happy to follow on with an approval right away 🚀
Some follow up items we should be aware of:
- we could soon use this in
@turnkey/sdk-browserfor passkey session creation! instead of relying onhpke-jssdk/packages/sdk-browser/src/utils.ts
Line 10 in dfd3657
- it would be really powerful to update tkhq/passkeyapp with more of these use cases, similar to the ones that we've seen recently (trying to perform email auth/recovery, and key or wallet import/export without iframes)
moe-dev
force-pushed
the
moe/add-hpke-encryption
branch
from
9d3d2f8
to
84886fd
Compare
r-n-o
reviewed
Jun 19, 2024
r-n-o
approved these changes
Jun 21, 2024
packages/crypto/README.md
Outdated
Comment on lines
19
to
21
| const plaintext = "Hello, this is a secure message!"; | ||
| const encryptedData = hpkeEncrypt({ | ||
| plainText: plaintext, |
There was a problem hiding this comment.
I think this needs to be updated now that you take a uint8array instead of a string
moe-dev
force-pushed
the
moe/add-hpke-encryption
branch
from
86a9109
to
e4ae66d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We got decryption so we may as well have encryption! Afaik, nothing really out there that supports e2e hpke decryption and encryption that can be used with any runtime, so why not :)
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.