Add oauth endpoints, Add oauth to allowed proxy methods #303
Conversation
moe-dev
requested review from
taylorjdawson,
r-n-o,
AlwaysBCoding and
andrewkmin
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| @@ -57,6 +57,7 @@ export default async function createUser( | |||
| attestation: createSubOrgRequest.attestation, | |||
| }, | |||
| ], | |||
| oauthProviders: [], | |||
There was a problem hiding this comment.
interesting. This means is a "breaking" change of sorts, at least at a code level. When customers update the SDK they'll have to update code as well. Not the end of the world but a bit annoying. As long as we're explicit about this in the CHANGELOG it shouldn't be a problem, it's a pretty trivial change to make!
There was a problem hiding this comment.
Yessir! CHANGELOG + make this a major release, and we should be good :)
There was a problem hiding this comment.
so if we're following semver this would be 1.0.0 for sdk-browser and sdk-server. I think that's fine to do and just start developing against the 1.x.x versions going forward, but it's probably something to be conscious of that we might not want to always have to bump major versions if we're constantly changing the activity API. So could possibly have a flow in the future for making backwards compatible changes where the legacy activity syntax still resolves.
(i.e. the sdk-client could default oauthProviders to [] if not provided so it doesn't break anyone's existing implementation by upgrading the library and it would only need to be a minor version bump)
but either way we can probably have a 1.x.x version at this point and just use this commit as the start of it if we want to
moe-dev
force-pushed
the
moe/sdk-update-oauth
branch
from
75c94d1
to
a1d7a1e
Compare
|
we're going to do a 1.0.0 release of sdk-server, sdk-browser and sdk-react off this PR |
Summary & Motivation
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.