Fix/clean-up low impact issues in libinjector and libusermode #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initialization of the scalar field func_add, which was uninitialized, what coverity detected as CID 304049
|
Can one of the admins verify this patch? |
jgru
changed the title
|
@drakvuf-jenkins This is OK to test |
jgru
force-pushed
the
fix-coverity-issues-libinjector-libusermode
branch
4 times, most recently
from
2bf4f2a
to
990b8a2
Compare
Remove unused value in print_injection_info(...), which was identified as CUD 309662 by coverity
Fix error handling in injector_int3_cb in win_injector.c by checking the return value from vmi_read. This prevents a call to vmi_convert_str_encoding(...) passing uninitialized data. This issue was identified by coverity as CID 307533
jgru
force-pushed
the
fix-coverity-issues-libinjector-libusermode
branch
from
990b8a2
to
383b001
Compare
skvl
added a commit
to skvl/drakvuf
that referenced
this pull request
Nov 11, 2021
tklengyel
pushed a commit
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Tamas,
this PR submits three patches, which fix the following issues identified by static code analysis with low to medium impact :
injector_int3_cb(...)by checking the return value fromvmi_read(...)print_injection_info(...)func_addrof structrh_data_tinuh-private.hppAlthough those are only minor changes, I think, they might help to declutter the results of static code analysis.
Thank you already advance for considering this PR.
Best regards
Jan
P.S.: I decided to not squash the commits this time, because they try to solve distinct issues. If you want me to do so, please let me know.