Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to configure size of thread local buffer to avoid message fragmentation #60

Closed
tkowalcz opened this issue Jul 5, 2021 · 0 comments · Fixed by #61
Closed

Ability to configure size of thread local buffer to avoid message fragmentation #60

tkowalcz opened this issue Jul 5, 2021 · 0 comments · Fixed by #61
Assignees
@tkowalcz
Labels
log4j2-appender Relates to Log4j2 Appender component

Comments

@tkowalcz
Copy link
Owner

tkowalcz commented Jul 5, 2021

Class ByteBufferDestinations which is used as a thread local contains a buffer object that is initialised to 10kb. All messages larger than 10kb will be fragmented.

It is possible that someone would log message larger than 10kb and not want it to be fragmented. The size of that buffer should be configurable. We do not want to support unbounded buffer growth due to possibility of DoS attack done by erroneous message.
@tkowalcz tkowalcz added the log4j2-appender Relates to Log4j2 Appender component label Jul 5, 2021
@tkowalcz tkowalcz self-assigned this Jul 5, 2021
tkowalcz added a commit that referenced this issue Jul 6, 2021
@tkowalcz
Re #60: Refactored ByteBufferDestinations to be a factor of buffers w…
bc42112 
…ith thread local caching and configurable buffer size.
tkowalcz added a commit that referenced this issue Jul 6, 2021
@tkowalcz
Re #60: Added test for message fragmentation and maxLogLineSizeKiloby…
8258443 
…tes setting.
tkowalcz added a commit that referenced this issue Jul 6, 2021
@tkowalcz
Re #60: Documented maxLogLineSizeKilobytes property.
961ef5e
@tkowalcz tkowalcz linked a pull request Jul 7, 2021 that will close this issue
60 configure buffer destination size #61
Merged
@tkowalcz tkowalcz closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkowalcz tkowalcz

Labels
log4j2-appender Relates to Log4j2 Appender component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

60 configure buffer destination size tkowalcz/tjahzi
1 participant
@tkowalcz