Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite parse_time so it understands time zones and microseconds #152

Merged
merged 6 commits into from Mar 2, 2019

Conversation

Zverik
Copy link

@Zverik Zverik commented Nov 1, 2018

Fixes #83, #114 and #148.

I decided to go with a precompiled regular expression. It should be fast, since there are no + or * special characters in it. Tested in Python 2.7 and 3.6.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 85.612% when pulling 9d89f9a on Zverik:fix_tz_and_micro into b9219a9 on tkrajina:master.

@coveralls
Copy link

coveralls commented Nov 1, 2018

Coverage Status

Coverage increased (+0.003%) to 85.524% when pulling c9d5b3a on Zverik:fix_tz_and_micro into 5358e8c on tkrajina:master.

@christianhauff
Copy link

Any progress on this PR? I just spent an hour on a timezone problem before I realized that gpxpy just ignores the timezone information.

@bstadlbauer
Copy link

Would it be possible to merge and release this as some point? Would be really helpful to support time zones 👍

@tkrajina
Copy link
Owner

Yes, I plan to merge this pull request. Before diving in the code @Zverik do you think this is now the final version or you have more things to commit here?

@Zverik
Copy link
Author

Zverik commented Feb 24, 2019

I think that's final: it's on par with the version we use in our company.

@tkrajina tkrajina merged commit b980520 into tkrajina:master Mar 2, 2019
@bstadlbauer
Copy link

Thanks for merging and releaseing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants