Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the NoOp message type from Game.elm #46

Closed
tkshill opened this issue Nov 7, 2020 · 2 comments · Fixed by #73
Closed

Remove the NoOp message type from Game.elm #46

tkshill opened this issue Nov 7, 2020 · 2 comments · Fixed by #73
Labels
Context: Refactor No fuctionality changes need apply good first issue Good for newcomers Status: Available This issue is free to be worked on. Type: Enhancement New feature or request

Comments

@tkshill
Copy link
Owner

tkshill commented Nov 7, 2020

Issue Context

In the Game.elm file, we've defined a NoOp Msg that we don't seem to actually need. For the sake of reducing the complexity of the code, it should be removed.

Suggested Solution

  • Remove the NoOp from the acceptable Msg cases in Game.elm
  • Remove the corresponding reference to it in the update function of Game.elm

Alternatives Considered

N/A

Additional Resources

You can take a peek at the file here before you start if you like.


See here in the read me for how to run and install the application.

See here in contributing for the basics on forking and cloning the repository.

@tkshill tkshill added Type: Enhancement New feature or request good first issue Good for newcomers Context: Refactor No fuctionality changes need apply labels Nov 7, 2020
@tkshill tkshill added this to To do in Elm Quarto Project via automation Nov 7, 2020
@github-actions
Copy link

github-actions bot commented Nov 7, 2020

Thank you for the issue! We'll take your request into consideration and will follow up soon if we decide to tackle this issue.
To all contributors: any issue that is labeled Status: Available is up for grabs.
To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please leave a comment letting us know and we can schedule some time to help.
For full info on how to contribute, please check out our contributors guide.

@tkshill tkshill added the Status: Available This issue is free to be worked on. label Nov 7, 2020
@Leoactionz
Copy link
Contributor

@tkshill, I would love to grab this as well. Any helpful resources will be appreciated

@Leoactionz Leoactionz mentioned this issue Oct 10, 2021
@tkshill tkshill linked a pull request Oct 10, 2021 that will close this issue
@tkshill tkshill closed this as completed Oct 10, 2021
Elm Quarto Project automation moved this from To do to Done Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Context: Refactor No fuctionality changes need apply good first issue Good for newcomers Status: Available This issue is free to be worked on. Type: Enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants