Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diff command #77

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Fix diff command #77

merged 3 commits into from
Aug 15, 2023

Conversation

kitagry
Copy link
Contributor

@kitagry kitagry commented Aug 13, 2023

fix #76

I fixed the above issue. But, this PR include some options which don't work. e.x.) --matching-groups.

Please feel free to close this PR, if you want to resolve this issue by the other way.

Thank you.

@tkuchiki
Copy link
Owner

@kitagry Thank you for creating an issue and PR!
I will review it tonight.

@tkuchiki @kitagry
[alp diff] Remove unused code
0e4d32a 
Co-authored-by: Ryo Kitagawa <kitadrum50@gmail.com>
@tkuchiki
Copy link
Owner

@kitagry I'm sorry for the late review.
I made some changes, so could you please review it, just in case?

@kitagry
Copy link
Contributor Author

kitagry commented Aug 14, 2023 •
edited
Loading

@tkuchiki Thank you for the proposal. I think if you delete --from and --to option, it is enough to use cobra.ExactArgs.

Could you review 70c89c4?

tkuchiki
tkuchiki approved these changes Aug 15, 2023
View reviewed changes
Copy link
Owner

@tkuchiki tkuchiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tkuchiki tkuchiki merged commit df82f8e into tkuchiki:main Aug 15, 2023
1 check passed
@tkuchiki
Copy link
Owner

tkuchiki commented Aug 15, 2023 •
edited
Loading

I plan to make the diff command to optional.
So I will release a new version when the implementation is complete.

$ cat access.log.json | alp diff dump.alp

$ alp diff dump.alp --file access.log.json

@kitagry kitagry deleted the fix-diff-command branch August 15, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkuchiki tkuchiki tkuchiki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diff command is broken
2 participants
@kitagry @tkuchiki