Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "XXXbase" to "XXXBase" #224

Merged
merged 8 commits into from
Jan 21, 2023
Merged

Rename "XXXbase" to "XXXBase" #224

merged 8 commits into from
Jan 21, 2023

Conversation

tky823
Copy link
Owner

@tky823 tky823 commented Jan 21, 2023

Summary

By this PR, all of XXXbase class is renamed to XXXBase. This change is based on the Python style guide.

close #223

@tky823 tky823 added documentation Improvements or additions to documentation notebooks Related to jupyter notebooks labels Jan 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Base: 94.66% // Head: 94.66% // No change to project coverage 👍

Coverage data is based on head (197b424) compared to base (db9cac0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files          38       38           
  Lines        4573     4573           
=======================================
  Hits         4329     4329           
  Misses        244      244           
Impacted Files Coverage Δ
ssspy/bss/cacgmm.py 92.06% <100.00%> (ø)
ssspy/bss/fdica.py 92.50% <100.00%> (ø)
ssspy/bss/ica.py 92.79% <100.00%> (ø)
ssspy/bss/ilrma.py 96.91% <100.00%> (ø)
ssspy/bss/ipsdta.py 89.71% <100.00%> (ø)
ssspy/bss/iva.py 96.20% <100.00%> (ø)
ssspy/bss/mnmf.py 95.62% <100.00%> (ø)
ssspy/bss/pdsbss.py 95.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tky823 tky823 merged commit 46061fb into main Jan 21, 2023
@tky823 tky823 deleted the fix/rename-base branch January 21, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation notebooks Related to jupyter notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "XXXbase" to "XXXBase"
2 participants