Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify flooring function in each method #228

Merged
merged 31 commits into from
Feb 5, 2023
Merged

Conversation

tky823
Copy link
Owner

@tky823 tky823 commented Feb 5, 2023

Summary

This PR allows us to customize a flooring function per method, improving mathematical operations' numerical stability.

@tky823 tky823 added the bss Blind source separation method label Feb 5, 2023
@tky823 tky823 added this to the v0.2.0 milestone Feb 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Base: 94.35% // Head: 94.39% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2677b1f) compared to base (32f5bcb).
Patch coverage: 96.58% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   94.35%   94.39%   +0.03%     
==========================================
  Files          39       41       +2     
  Lines        4981     5122     +141     
==========================================
+ Hits         4700     4835     +135     
- Misses        281      287       +6     
Impacted Files Coverage Δ
ssspy/bss/_flooring.py 0.00% <0.00%> (ø)
ssspy/bss/_update_spatial_model.py 99.00% <ø> (ø)
ssspy/utils/flooring.py 76.92% <76.92%> (ø)
ssspy/bss/ipsdta.py 90.04% <94.11%> (+0.32%) ⬆️
ssspy/bss/fdica.py 92.42% <94.44%> (+0.11%) ⬆️
ssspy/bss/iva.py 96.23% <97.22%> (+0.04%) ⬆️
ssspy/bss/ilrma.py 97.01% <98.75%> (+0.10%) ⬆️
ssspy/bss/_psd.py 100.00% <100.00%> (ø)
ssspy/bss/cacgmm.py 90.73% <100.00%> (+0.25%) ⬆️
ssspy/bss/mnmf.py 94.47% <100.00%> (+0.17%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tky823 tky823 merged commit 10d3c9a into main Feb 5, 2023
@tky823 tky823 deleted the feature/methodwise-flooring branch February 5, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bss Blind source separation method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants