Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize IVA-IPA related algorithms #241

Merged
merged 5 commits into from
Aug 12, 2023
Merged

Stabilize IVA-IPA related algorithms #241

merged 5 commits into from
Aug 12, 2023

Conversation

tky823
Copy link
Owner

@tky823 tky823 commented Jul 17, 2023

Summary

This PR improves the stability of IVA-IPA.

  1. Inversion of a positive semidefinite matrix is based on eigenvalue decomposition.
  2. Set v and phi by 0 when phi * np.abs(v) ** 2 is small.

close #239

@tky823 tky823 added new feature New feature or request bss Blind source separation method test Test related issue math Math related issue labels Jul 17, 2023
@tky823 tky823 added this to the v0.2.0 milestone Jul 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: -0.04% ⚠️

Comparison is base (99aa54e) 94.03% compared to head (742ab5e) 93.99%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   94.03%   93.99%   -0.04%     
==========================================
  Files          44       44              
  Lines        5363     5366       +3     
==========================================
+ Hits         5043     5044       +1     
- Misses        320      322       +2     
Files Changed Coverage Δ
ssspy/special/psd.py 100.00% <ø> (ø)
ssspy/bss/_update_spatial_model.py 98.51% <90.90%> (-0.34%) ⬇️
ssspy/linalg/lqpqm.py 92.91% <95.00%> (+0.12%) ⬆️
ssspy/bss/_psd.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tky823 tky823 merged commit ad6fb13 into main Aug 12, 2023
14 checks passed
@tky823 tky823 deleted the feature/stable-ipa branch August 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bss Blind source separation method math Math related issue new feature New feature or request test Test related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numerical instability of IPA
2 participants