Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STUDENT_DASHBOARD_LTI should be renamed #1094

Closed
jonespm opened this issue Sep 17, 2020 · 4 comments · Fixed by #1405
Closed

STUDENT_DASHBOARD_LTI should be renamed #1094

jonespm opened this issue Sep 17, 2020 · 4 comments · Fixed by #1405
Assignees
@jonespm
Labels
🪳 bug Something isn't working config change needed Changes are needed/included that may affect configuration files SAML
Projects
MyLA-2022.01.03

Comments

@jonespm
Copy link
Member

jonespm commented Sep 17, 2020

The config value "STUDENT_DASHBOARD_LTI" should really be something like

ENABLE_LTI

Since the project is no longer student dashboard. We also have STUDENT_DASHBOARD_SAML but that should be deprecated.

You'd want both to work so use the STUDENT_DASHBOARD_LTI as the default value if this isn't set for backward compatibility.

ENV.get('ENABLE_LTI', ENV.get('STUDENT_DASHBOARD_LTI', False))

my-learning-analytics/config/env_sample.json

Line 94 in a3f624f

"STUDENT_DASHBOARD_LTI": false,

@jonespm jonespm added 🪳 bug Something isn't working config change needed Changes are needed/included that may affect configuration files labels Sep 17, 2020
@project-bot project-bot bot added this to To do in MyLA-Default-Project Sep 17, 2020
@jonespm jonespm removed this from To do in MyLA-Default-Project Jan 29, 2021
@jonespm
Copy link
Member Author

jonespm commented Jan 29, 2021

This setting can probably be removed with #1212

@jonespm jonespm added the SAML label Jan 29, 2021
@jennlove-um jennlove-um added this to To do in MyLA-2022.02.01 via automation Nov 17, 2021
@jonespm jonespm self-assigned this Nov 18, 2021
@jonespm
Copy link
Member Author

jonespm commented Nov 18, 2021

#1212 was done but this still should be cleaned up too.

jonespm added a commit to jonespm/student-dashboard-django that referenced this issue Aug 25, 2022
@jonespm
Fixes tl-its-umich-edu#1094 - STUDENT_DASHBOARD_LTI should be renamed
8e66d7d
@jonespm jonespm moved this from To do to In progress in MyLA-2022.02.01 Aug 25, 2022
@jonespm jonespm linked a pull request Aug 25, 2022 that will close this issue
Fixes #1094 - STUDENT_DASHBOARD_LTI should be renamed #1405
Merged
MyLA-2022.02.01 automation moved this from In progress to Review/QA Aug 31, 2022
jonespm added a commit that referenced this issue Aug 31, 2022
@jonespm
Fixes #1094 - STUDENT_DASHBOARD_LTI should be renamed (#1405)
c5af6df
@pushyamig pushyamig moved this from Review/QA to Review/QA - DEV in MyLA-2022.02.01 Sep 19, 2022
@pushyamig
Copy link
Contributor

I will QA this.

@pushyamig
Copy link
Contributor

I used the old key STUDENT_DASHBOARD_LTI = true and I can see the test passing
I used the new key Enable_LTI=true and test passes.

Test Passes

@pushyamig pushyamig moved this from Review/QA - DEV to Done in MyLA-2022.02.01 Sep 19, 2022
@jennlove-um jennlove-um removed this from Done in MyLA-2022.02.01 Sep 20, 2022
@jennlove-um jennlove-um added this to To do in MyLA-2022.01.03 via automation Sep 20, 2022
@pushyamig pushyamig moved this from To do to Done in MyLA-2022.01.03 Sep 20, 2022
jonespm added a commit to jonespm/student-dashboard-django that referenced this issue Sep 20, 2022
@jonespm
Fixes tl-its-umich-edu#1094 - STUDENT_DASHBOARD_LTI should be renamed (…
590ba02 
…tl-its-umich-edu#1405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonespm jonespm

Labels
🪳 bug Something isn't working config change needed Changes are needed/included that may affect configuration files SAML
Projects
No open projects
MyLA-2022.01.03
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1094 - STUDENT_DASHBOARD_LTI should be renamed jonespm/student-dashboard-django
2 participants
@jonespm @pushyamig