Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-14 still referenced in Dockerfile to 16 #1374

Closed
jonespm opened this issue Apr 27, 2022 · 2 comments · Fixed by #1375
Closed

Update node-14 still referenced in Dockerfile to 16 #1374

jonespm opened this issue Apr 27, 2022 · 2 comments · Fixed by #1375
Assignees
Labels
🪳 bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@jonespm
Copy link
Member

jonespm commented Apr 27, 2022

Also update Dockerfile.openshift

This looks like was missed as part of #1312

FROM node:14-slim AS node-prod-deps

@jonespm jonespm added this to To do in MyLA-2022.01.01 via automation Apr 27, 2022
@jonespm
Copy link
Member Author

jonespm commented Apr 27, 2022

This might have been why some of the irregularities were noticed on that PR while we were testing this. It looks like it builds prod deps separate from the webpack.

I'd like to clean up this build and have it all as one phase or maybe 2 like Canvas App Explorer but haven't gotten around to doing that.

MyLA-2022.01.01 automation moved this from To do to Done Apr 27, 2022
@ssciolla ssciolla added the 🪳 bug Something isn't working label Apr 27, 2022
@ssciolla ssciolla moved this from Done to QA-dev in MyLA-2022.01.01 Apr 27, 2022
@ssciolla ssciolla added the dependencies Pull requests that update a dependency file label Apr 27, 2022
@jonespm
Copy link
Member Author

jonespm commented Apr 29, 2022

Verified from the build logs that this builds and node:16 is now the only one referenced.

@jonespm jonespm moved this from QA-dev to Done in MyLA-2022.01.01 Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working dependencies Pull requests that update a dependency file
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants