Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend dependencies #1312

Closed
ssciolla opened this issue Sep 3, 2021 · 1 comment · Fixed by #1363
Closed

Upgrade frontend dependencies #1312

ssciolla opened this issue Sep 3, 2021 · 1 comment · Fixed by #1363
Assignees
Labels
dependencies Pull requests that update a dependency file 📈 enhancement New feature or request Frontend

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Sep 3, 2021

This would be the logical next step after #1286, though it may not need to be done immediately.

As part of this, we should also evaluate the usage of django-npm. I looked into removing it (because it's unmaintained) as part of the aforementioned issue, but doing so resulted in some style changes (loss of icons and screenreader text started showing up visually). It would make sense to look at this in conjunction with the frontend dependencies. I don't think it's strictly necessary, but it would require some changes and testing to ensure nothing is broken. Also, it looks like jquery is being pulled in through this strategy (see settings.py, NPM_FILE_PATTERNS, but it may not be used anywhere.

@ssciolla
Copy link
Contributor Author

Let's make sure to test Google Analytics when testing this.

ssciolla added a commit that referenced this issue Apr 21, 2022
* Bump to Node 16; remove node-sass

* Bump a bunch of packages, run npm audit fix; fix webpack deprecations

* Start fixing @apollo/client

* Turn graphiql page off when not in DEBUG mode

* Update jest dependencies

* Remove jquery reference in settings

* Make URI relative; remove trailing comma

* Adopt recommended react-router-dom patterns for version 5

* Use latest d3 version 5 release explicitly

* Remove separate installation, configuration of jest-pnp-resolver

* Remove use of deprecated RootRef in anticipation of material-ui upgrade

* Remove unnecessary(?) extra ref usage

* Refactor to RootRef usage from TableAssignment, retain currentWeek scroll

* Remove unused clearButton class in AssignmentPlanningV2

* Try to resolve Codacy issue related to undefined

* Try to tidy up fontawesome usages; bump django-webpack-loader

* Use Python/Django fontawesomefree library to support CSS; remove django-npm

* Tweak spacing, alignment, and sizing around icon checkboxes

* Bump some more npm packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file 📈 enhancement New feature or request Frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant