New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loophole does not work with Django Admin and returns incorrect URLs in /lti/config #1402
Comments
…_HOST. This is Needed for some proxies.
…_HOST. This is Needed for some proxies.
…_HOST. This is Needed for some proxies.
Test Plan
|
Test passes and is working for me based on setting certain TRUSTED_ORIGINS in my local |
…_HOST. (tl-its-umich-edu#1403) This is Needed for some proxies.
Describe the bug (Tell us what happens instead of the expected behavior) :
If a local developer is using loophole.site instead of ngrok for LTI testing it doesn't work correctly. This is because loophole sends the header USE_X_FORWARDED_HOST and MyLA currently doesn't use this.
Steps to Reproduce :
You can launch loophole with a command like
loophole http 5001 --hostname myla-test-domain
After you go through the steps to install it and add it to your path.
Everything should just work the same was as with NGrok.
It's possible to configure this you may also have to add loophole.site to
ALLOWED_HOSTS, DEFAULT_SRC and CSRF_TRUSTED_ORIGINS.
The text was updated successfully, but these errors were encountered: