Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, replace, or remove Cypress tests #1418

Closed
ssciolla opened this issue Aug 31, 2022 · 4 comments · Fixed by #1485
Closed

Fix, replace, or remove Cypress tests #1418

ssciolla opened this issue Aug 31, 2022 · 4 comments · Fixed by #1485
Assignees
Labels
🪳 bug Something isn't working

Comments

@ssciolla
Copy link
Contributor

Currently, the Cypress tests don't run as is following the provided instructions. It seems like there is a dependency issue with cypress-plugin-snapshots (which is unmaintained and not compatible with the latest cypress major version). See meinaart/cypress-plugin-snapshots#215 about possible updates. But even if you pin it to the compatible version, many tests don't pass. This is likely either because the dump data changed or snapshots haven't been updated.

I'll add a note about the issues in the relevant docs, but at some point, it would be nice to get this working, replace it with something like Playwright, or just remove it if we don't plan to keep it up to date.

@ssciolla ssciolla added the 🪳 bug Something isn't working label Aug 31, 2022
@jennlove-um jennlove-um added this to To do in MyLA-2023.01.02 via automation Feb 15, 2023
@jonespm
Copy link
Member

jonespm commented Feb 16, 2023

Additional cleanup:

@jennlove-um
Copy link
Contributor

Remove the Cypress tests.

@pushyamig pushyamig moved this from To do to In progress in MyLA-2023.01.02 Feb 27, 2023
pushyamig added a commit to pushyamig/my-learning-analytics that referenced this issue Feb 27, 2023
MyLA-2023.01.02 automation moved this from In progress to Review/QA Mar 7, 2023
pushyamig added a commit that referenced this issue Mar 7, 2023
@pushyamig pushyamig moved this from Review/QA to Review/QA - DEV in MyLA-2023.01.02 Mar 24, 2023
@pushyamig
Copy link
Contributor

@jonespm can you QA this?

@jonespm
Copy link
Member

jonespm commented Apr 6, 2023

I see that they're removed, I don't see any references to cypress.

@jonespm jonespm moved this from Review/QA - DEV to Done in MyLA-2023.01.02 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants