Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning about courses added during cron is falsely reporting all courses #1476

Closed
ssciolla opened this issue Jan 30, 2023 · 1 comment · Fixed by #1477
Closed

Log warning about courses added during cron is falsely reporting all courses #1476

ssciolla opened this issue Jan 30, 2023 · 1 comment · Fixed by #1477
Assignees
@zqian @ssciolla
Labels
🪳 bug Something isn't working 📅 cron
Projects
MyLA-2023.01.01

Comments

@ssciolla
Copy link
Contributor

Thank you for contributing to this project!

  • Make sure to search the issues for duplicates first!

Expected behavior (A description of what you expected to happen) :

The log warning near the end of the run of cron.py should warn users only about courses that were added to the system during the cron run.

Describe the bug (Tell us what happens instead of the expected behavior) :

During cron runs, all of the course IDs are reported by this log message. This seems to be because of a cast of course IDs
to strings added in this commit: 141081a
@ssciolla ssciolla added 🪳 bug Something isn't working 📅 cron labels Jan 30, 2023
@jennlove-um jennlove-um added this to To do in MyLA-2023.01.01 via automation Jan 31, 2023
@ssciolla ssciolla mentioned this issue Jan 31, 2023
Merged
MyLA-2023.01.01 automation moved this from To do to Review/QA Jan 31, 2023
ssciolla added a commit that referenced this issue Jan 31, 2023
@ssciolla
Fix use of log warning of added courses by creating separate string I…
58dd7f6 
…D list (#1476) (#1477)

* Prepare and use separate list of string IDs

* Make valid_locked_course_ids list[str], add a few types; downgrade log to debug
@jennlove-um
Copy link
Contributor

testing passes in beta

@jennlove-um jennlove-um moved this from Review/QA to Done in MyLA-2023.01.01 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zqian zqian

@ssciolla ssciolla

Labels
🪳 bug Something isn't working 📅 cron
Projects
No open projects
MyLA-2023.01.01
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix log warning of added courses (#1476) ssciolla/my-learning-analytics
3 participants
@zqian @ssciolla @jennlove-um